Fixes to allow the code to run with the EAGLE model spawning stars

Changes:

• When reordering the extra gpart, also take care of potential links with BHs
• The SF can also change the number of gpart. We must thus also exchange the number of gpart created with the other nodes at the level where gravity comms are and not just at the hydro super level.
• Modify the SF task to be able to create an arbitrary number of stars with or without converting the gas particle.
• Modify the EAGLE SF model to allow for the creation of more than 1 star particle / SF event.

Todo:

• Clean-up debugging messages
• Activate the extra comm only if a scheme uses particle spawning? --> Can't do that as it's decided on a particle-by-particle basis in GEAR.
• Make the number of stars formed by the EAGLE model a runtime parameter?
• Not break the GEAR model that spaws but lets the gas particle survive.

added EAGLE bug labels

assigned to @matthieu

added 1 commit

• 2284fd70 - Version working on EAGLE-50 low-z

Compare with previous version

added 1 commit

• 3528e020 - Applied formatting script

Compare with previous version

added 21 commits

• 3528e020...f36ebb5f - 20 commits from branch master
• cb6686f1 - Merge branch 'master' into fix_eagle_part_spawning

Compare with previous version

changed the description

mentioned in merge request !1959 (closed)

added 3 commits

• b0932bf8 - Also activate the new gpart count communication tasks in the marktasks() function.
• 72fe7d2e - Fix incorrect debugging checks in the SF packing and gpart packing functions
• 8e564039 - Do not add the SF->gpart_count_send unlocks if the top-level cell does not have hydro particles

Compare with previous version

added 1 commit

• cf1ffd43 - Remove entirely unnecessary checks

Compare with previous version

Todo: Check what happens with checks on and limiter.

mentioned in merge request !1975 (closed)

added 65 commits

• cf1ffd43...a601a079 - 58 commits from branch master
• 3d835b46 - When reordering the extra gpart, also take care of potential links with BHs
• c703ed09 - Version working on EAGLE-50 low-z
• c81eb1f0 - Applied formatting script
• cb1b519f - Also activate the new gpart count communication tasks in the marktasks() function.
• 3564995b - Fix incorrect debugging checks in the SF packing and gpart packing functions
• 61a1c515 - Do not add the SF->gpart_count_send unlocks if the top-level cell does not have hydro particles
• f793811a - Remove entirely unnecessary checks

Compare with previous version

added 1 commit

• 3c2e4594 - Remove unwanted debugging checks

Compare with previous version

marked this merge request as ready

marked the checklist item Clean-up debugging messages as completed

added 1 commit

• 0ad284f6 - Split the packed structure for SF into two: a gravity and stars one

Compare with previous version

added 19 commits

• 0ad284f6...5b139c59 - 18 commits from branch master
• b73f1e90 - Merge branch 'master' into fix_eagle_part_spawning

Compare with previous version

added 1 commit

• 4d4db905 - Code formatting

Compare with previous version

added 2 commits

• c0d191ed - Better defaults for the extra spart and gparts
• f3417f41 - Undo parameter file changes made for debugging

Compare with previous version