Skip to content

Draft: MPI for sink particles

Darwin requested to merge darwin/sink_mpi into master

Done so far:

  • Sink particle exchange with the proxies (proxy.h/.c, engine_strays.c, etc.)
  • Tasks implementation
  • cell_unskip is up to date, but not engine_marktasks

To do:

  • Clean up debugging messages (some may be worth to be kept)
  • Clean up/update comments
  • Check some comments I left alongside the black holes when I found weird things/potential bugs.
  • Add !1938 for sink particles
  • I disabled calls to gravity functions in GEAR sink sink_iact.h. Move these to some sink_data/sink_merger attribute (similar to potential) to avoid MPI issues when the cells are foreign.
  • Check compilation with Default sink
  • Take into account the fact that we can use SF and SF_sink at the same time --> use a different sf_counts for SF_sink

Documentation:

  • Add a list of MPI-related files
  • Update the sink doc to say where we can call gpart and when we cannot to avoid MPI issues.
Edited by Darwin

Merge request reports