Skip to content
Snippets Groups Projects

Improve the hydro task splitting logic to take into account the star content of cells as well.

Merged Matthieu Schaller requested to merge star_task_split_criterion into master
All threads resolved!

When deciding whether to split a hydro task, also consider the stellar content was we may want to create smaller tasks for better efficiency at late times in simulations.

Should help with #584.

Edited by Matthieu Schaller

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Matthieu Schaller resolved all discussions

    resolved all discussions

  • added 1 commit

    • 0813f556 - Fixed typo in the hydro-only task splitting criterion. Need to consider both ci…

    Compare with previous version

  • Matthieu Schaller resolved all discussions

    resolved all discussions

  • All looks good to me. Ready to accept? Do you want to keep the branch?

  • Yes, thanks. The branch can go.

    If there are free cores and you have some time, testing this with various values of the new parameters may be interesting.

  • Peter W. Draper mentioned in commit ca9ba095

    mentioned in commit ca9ba095

  • Please register or sign in to reply
    Loading