Star formation (non-MPI)

A bunch of new physics and infrastructure added to the code:

• Remove the sourceterm files. Feedback will be handled differently.
• Recycled the runtime flag -F for star formation.
• When rebuilding, we allocate extra space at the end of the array of each top-level cell for spare particles to be used in on-the-fly creation.
• These particles do not enter any calculation.
• When we want to create a star, we shift all the spart by one slot in order to eat up one of these spares. We update the pointers and counters in that cell hierarchy accordingly.
• That creates a free slot at the start of the cell's array. This is the new particle.
• Added functions to convert a part into a spart.

This should not break anything as we do not use the -F flag by default for now. I can run the EAGLE examples smoothly with the new flag. These tests will become more meaningful when the star formation law is more physically motivated.

The MPI-version will follow soon.

mentioned in merge request !684 (closed)

changed title from Add particles to Star formation (non-MPI)

changed the description

added 1 commit

• c74e0ea5 - Doxygen and RTD documentation fixes

Compare with previous version

added 94 commits

• c74e0ea5...f37c38a3 - 92 commits from branch master
• f78cb5bd - Merge branch 'master' into add_particles
• 187062ab - Change the -F flag from sourceterms to star formation.

Compare with previous version

assigned to @pdraper

added 284 commits

• 187062ab...e968d966 - 283 commits from branch master
• 7ba384f4 - Merge branch 'master' into add_particles

Compare with previous version

Can I help with reviewing this one? Any test you would like to see?

Sorry for the slowness, just very busy this week. I started looking at this yesterday, so just hold on for a little longer!

No rush. :)

All seems, good even tried an EAGLE_50 with --star-formation, so far has got to step 10. Very slow as I used:

./configure --enable-debug --enable-debugging-checks --disable-hand-vec --enable-sanitizer --enable-undefined-sanitizer

(just wrote the restart files, so that is slow).

That is slow indeed! I have some optimizations down the line but wanted to have the functionality in place first.

Look at that configure line closely...

I know :) But nevertheless, the SF task itself is much slower than it ought to be.

I haven't found any problems with this, so will accept so you can make progress and we can see what Jenkins thinks. OK with you?

Yes, perfect, thanks.

merged

mentioned in commit bc4b31a9