Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • SWIFTsim SWIFTsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 56
    • Issues 56
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 17
    • Merge requests 17
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • SWIFT
  • SWIFTsimSWIFTsim
  • Merge requests
  • !318

Added smoothing length correction limiter to Gizmo hydro_predict_extra.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Bert Vandenbroucke requested to merge gizmo_fix into master Mar 07, 2017
  • Overview 3
  • Commits 7
  • Changes 3

For some reason, the smoothing length prediction in GIZMO sometimes goes completely wrong, causing the code to crash in space_regrid, see #271 (closed). To overcome this, I have added a limit on the increase in smoothing length during the prediction step for GIZMO. This appears to solve the issue @jwillis was having with the EAGLE_12 test (I am currently testing it on one of my machines, and it's still running after 6000 steps).

I'm not sure it is worth looking into the cause of the bad smoothing length predictions. The smoothing length update is computed based on a mixture of SPH and GIZMO variables, so this is bound to go wrong sometimes. Maybe there are smarter ways to do this.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gizmo_fix