Skip to content
Snippets Groups Projects

Local variable cleanup

Merged Pedro Gonnet requested to merge local_variable_cleanup into master

First batch of formatting fixes, submitting these before things get massively out of sync again.

I've tried to apply the following rules throughout the code:

  • Local variables should be declared within the scope in which they are used.
  • Read-only variables should be declared const.
  • Local variables used in only a limit range of the scope should get their own scope.

I've also tried being a bit more explicit in variable and function naming.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
53 53 void printParticle(struct part *parts, struct xpart *xparts, long long int id,
54 54 int N) {
55 55
  • Peter W. Draper Added 21 commits:

    Added 21 commits:

  • The merge request needed updating against master, so I've done that. Better give it a once over before I accept.

  • 53 53 void printParticle(struct part *parts, struct xpart *xparts, long long int id,
    54 54 int N) {
    55 55
  • Author Developer

    LGTM!

  • Peter W. Draper mentioned in commit 1f9e985c

    mentioned in commit 1f9e985c

  • Peter W. Draper Added 11 commits:

    Added 11 commits:

  • Another merge conflict with size_t, fixed that and accepting quickly..

    OK to remove branch?

  • Peter W. Draper mentioned in commit 3e0e0c69

    mentioned in commit 3e0e0c69

  • Peter W. Draper Status changed to merged

    Status changed to merged

  • Author Developer

    Please don't remove the branch! Will clean up the for-loops next :)

  • OK, remember to pull this branch before making any further changes.

  • Author Developer

    Will do, thanks!

  • Please register or sign in to reply
    Loading