Skip to content
Snippets Groups Projects

Small GEAR merge fixes

Merged Matthieu Schaller requested to merge gear_cleanup into master

Bunch of small fixes:

  • Change the order of the parameters of cooling_cool_part() to match what was already done in one of the forks,
  • Clean-up comments in Makefile.am,
  • Clean-up the example parameter file.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I think I did not break anything but let me know if I did. :smile: We had already added the time parameter in one of the forks, just not at the same position in the argument order. This helps merging things.

    One more question: why is the task order set to none (i.e. the EAGLE one) when configuring with --with-subgrid=GEAR? Thought a different order was needed.

    Edited by Matthieu Schaller
  • It seems to be fine.

    Did I forget to explain it in the previous merge request? For the comparison between the two codes, I am trying to be as close as possible from GEAR, but for the future simulations, I am planning to use EAGLE's order. From my experience changing the task order does not have a large effect (at least the difference EAGLE / GEAR) and it is more simple for us to follow your way.

  • Ok... Then not sure why we kept the whole feature to change things if it is not used. I am never a fan of maintaining dead code.

  • Therefore I propose to keep it like this, open an issue about removing it and I will do it once I release GEAR

  • Sounds good.

  • mentioned in commit 8e668947

Please register or sign in to reply
Loading