Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • SWIFTsim SWIFTsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 53
    • Issues 53
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 19
    • Merge requests 19
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar

Admin message

gitlab has been updated to version 16

  • SWIFT
  • SWIFTsimSWIFTsim
  • Merge requests
  • !972

Logger dimensionality compilation error fix

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Bert Vandenbroucke requested to merge logger_dimensionality_fix into master Nov 29, 2019
  • Overview 0
  • Commits 1
  • Changes 1

Made sure logger_particle vector variables have size 3 to fix a compilation error when configuring with hydro dimension =/= 3.

Since we do not expect to ever use the logger for very large 1D or 2D simulations, I just changed the array sizes to 3, irrespective of the actual number of dimensions. This causes a minor memory overhead. The alternative solution would have been to explicitly check the dimensionality whenever accessing these arrays and that would have been ugly.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: logger_dimensionality_fix