Clarify box_wrap

Currently the implementation of box_wrap is wrong. The box size is b - a and not simply b. As we are always assuming a == 0, the code works fine. Here I am removing the parameter a. If you prefer, I can also simply update the box size in the wrap.

Thanks for noticing this. Can be fix box_wrap() to correctly do what it says rather than changing the code throughout? That will also allow to not break other people's code.

added 1 commit

• 81f08e3f - Fix box_wrap

Compare with previous version

Done.

I choose the first one in order to be safe in term of computational time, but I guess that as _a is 0, the compiler will be clever enough.

Great. Thanks. Never assume what the compiler does. Tools like https://godbolt.org/ can be helpful.

https://godbolt.org/z/gj4tr7

Try commenting out the lines 26 or 28 to see what box_wrap() and box_wrap2() get compiled into. You'll see it's the same.

added 1 commit

• 21eaa8f4 - Clarified the behaviour in the comment.

Compare with previous version

merged

mentioned in commit c25515f3

Thanks!