Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • SWIFTsim SWIFTsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 57
    • Issues 57
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 18
    • Merge requests 18
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • SWIFT
  • SWIFTsimSWIFTsim
  • Merge requests
  • !90

Improved multi-timestep SPH

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Matthieu Schaller requested to merge smoothing_length_derivative into master Feb 14, 2016
  • Overview 8
  • Commits 49
  • Changes

This brings a range of improvement, mostly minor and of code clarity nature to the code. It solves:

  • Issue #84 (closed). Particles are now <128 Bytes in size.
  • Issue #85 (closed). Smoothing-lengths now evolve more accurately and we implement a time-step criterion more conservative than default Gadget-2 but that is part of EAGLE.
  • Issue #88 (closed). We now have a 'minimal' hydro implementation that can be used both as a template and an example. The doxygen documentation is based on that version. The documentation is now very extensive. This model is a poor SPH implementation and should only be used to understand the structure of the code and not be seriously run.
  • Issue #95 (closed). The engine_collect_kick() function now correctly skips empty cells.
  • Issue #96 (closed). Conserved quantities are now written to a file. We need gravity before this really get useful.
  • The description of the SPH flavour in the HDF5 files is now moved to the hydro_io.h files for consistency.

Most of it are straight-forward changes. Note that this does not fix the issue we have in MPI mode.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: smoothing_length_derivative