Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • SWIFTsim SWIFTsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 53
    • Issues 53
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 19
    • Merge requests 19
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • SWIFT
  • SWIFTsimSWIFTsim
  • Merge requests
  • !891

Backported the new interface to the chemistry from the COLIBRE fork.

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Matthieu Schaller requested to merge colibre_backport into master Aug 14, 2019
  • Overview 9
  • Commits 1
  • Changes 6

This is an update that comes from our higher-resolution model fork but that I'd like to backport as it is useful in general but it touches the chemistry API.

The idea is to add a bunch of functions to the chemisty interface that return what Z and what the individual metal array is to be used in the different sections of the code (SF, feedback, cooling). The idea is then that these modules do not have to know what the exact structure of the chemistry data is. In our case it allows us to switch between a model that uses smoothed metals and one that doesn't just by changing the compilation flag for chemistry.

It does not break GEAR but maybe you want to adopt the same chemistry functions as well. Feel free to push to this branch if you want to.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: colibre_backport