Logger move task

Currently, the logger writes the particles after the kick1. It means that the velocities are at t + 0.5 dt and the positions are at t. The only place where both are synchronized is after the kick2, therefore this merge request is moving the task after the kick2.

I am also changing runner_do_logger. We are currently writing the particles when they start. I am changing this in order to write them at the end of their step.

@nnrw56 We can discuss it tomorrow.

assigned to @lhausammann

assigned to @nnrw56

I have checked the order of the operations:

• write the time stamp ti_current
• drift and kick the particles to ti_current
• write the particles if part_is_active

@matthieu, does it makes sense to you? The point where I am the least confident is the part_is_active.

Why are you imposing a dependency kick2->logger->timestep? Do you need the logger to be done before the next timestep calculation?

There is no need indeed, but I need at least a dependency to kick1. Do you prefer to have it directly to the kick1 task?

(forgot to provide the dependency graph)

Then I rephrase my question, does it need to be before the SF task?

No it does not. I will anyway need to write the particles before deleting them / after creating them.

Where do you want to put it? In between the timestep and the kick1?

I don't know. Just wondering about the dependences. Essentially, can it be done at the same time as something else like SF or can it not?

The only task that can be done in parallel is the time step one.

For the others we can write before or after, but not at the same time:

• Density is not possible because we are updating the smoothing length and some people will be interested in writing them.
• Feedback is not possible because the energy changes.
• Star formation is not possible because we are transforming particles and therefore it will become unpredictable.

Therefore I see two possibilities: either we keep everything like this or we move it at the same time than the time step.

Ok. That's fine. Making sure this was all thought through. :)

BTW, where you aiming to merge this into master?

assigned to @matthieu

unmarked as a Work In Progress

changed the description

Actually, there are merge conflicts to solve first.

added 88 commits

• 667ecbd2...2ae2ec49 - 85 commits from branch master
• ffb66f2e - Logger: move logger task after kick2
• 38dc2146 - Logger: change is_starting to is_active
• 1b904236 - Logger: No need of the logger task when compiled without

Compare with previous version

Should be fine now

merged

mentioned in commit a8b67b2c

FYI, that did not work at all. I had to push 8e0116a6 to get it to work. As soon as any task splitting was happening the code would break.