Black holes repositioning

This is the last bit of physics of the EAGLE model.

• When looping over the neighbours of a black hole, compute the minimal gravitational potential across all neighbours,
• When drifting, if the minimum is not yourself, move the BH to its new position.
• Force the code to compile with potential calculations switched on when using EAGLE physics.

added 1 commit

• bbe76f7c - Fix documentation strings and compilation of the default BH model.

Compare with previous version

added 1 commit

• 3421b494 - Remove message, fix documentation and fix debugging check.

Compare with previous version

resolved all discussions

Thanks Peter; I have fixed both of these.

Thanks, spotted another debug message that also needs to go.

Currently running this on EAGLE_6/.1 (non-MPI) and seeing a lot of output from this code, along with swallowing. Seems far more active than I remember. Had 6 BH swallow event in 1000 steps.

For reference this run also output:

random.h:110:45: runtime error: left shift of 3735 by 20 places cannot be represented in type 'int'

which I'm guessing is OK for the tricks that sort of code gets up to (sanitizers are enabled).

added 6 commits

• 3421b494...001587d2 - 4 commits from branch master
• d46bd191 - Removed one more debugging message.
• 3415c102 - Merge branch 'master' into black_holes_repositioning

Compare with previous version

resolved all discussions

Thanks. I have also removed it.

Indeed the repositioning should help a lot with the swallowing as BH will not be physically positioned at the same position. We also improved the random number generator's behaviour in low-probability cases, which may help with the gas swallowing.

For the RNG message, which sanitizer is that with? May not be as innocuous as it seems.

added 2 commits

• fd8a569c - 1 commit from branch master
• ec1dcaf1 - Merge branch 'master' into black_holes_repositioning

Compare with previous version

That message came from the undefined sanitizer, i.e what you get when configuring with --enable-undefined-sanitizer, guess -fsanitize=shift is the one from the large list of checks that enables.

Thanks. I have opened an issue for this.

Was there anything else that needed testing on this branch?

Not that I can see. May as well see what Jenkins thinks.

That's fine by me. Thanks.

merged

mentioned in commit 209dc39d

Good. Accepted.