Fix rare removing particles bug
Fix a weird, rare crash that occasionally appears when removing a particle in the same step as writing a snapshot.
Merge request reports
Activity
added 64 commits
-
1c527741...13f05c12 - 63 commits from branch
master
- 2d2922e9 - Merge branch 'master' into lock_before_removing_particles_debug
-
1c527741...13f05c12 - 63 commits from branch
No rush since it seems to work for me on the branch as is. And most of the changes are just aesthetic or typos apart from this fix. I guess we don't know exactly which fix attempts were needed in the end...
Let me know if I can help with testing
Edited by Jacob Kegerreis@jkeger could you cross-check that my latest changes did not break anything on your side? I have become paranoid...
assigned to @pdraper
@pdraper I think this is all fine but since we have been scratching our head a lot on this with Jacob, I'd appreciate an additional look.
The idea is that the cell_remove_xxxx now also remove the gpart friend. This is to avoid any issues of double-removing and thread synchronization.
mentioned in commit 68aef9ad