Change Default SPH (to actually work) (!841) · Merge requests · SWIFT / SWIFTsim · GitLab

Snippets Groups Projects

Merged Josh Borrow requested to merge fix-default-sph into master 5 years ago

All threads resolved!

This MR:

Changes the Default SPH implementation to actually compile and run tests, now using the ANARCHY viscosity switch and the PHANTOM SPH diffusion;
Removes two unused tests testSingle.c and testSPHStep.c that were always only activated in the case of DEFAULT_SPH that did not work,

Activity

Josh Borrow @jborrow 5 years ago

Author Developer

With this and !840 (merged) the phantom-diffusion-model branch can also be removed.
Matthieu Schaller @matthieu started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Josh Borrow
Last reply by Josh Borrow 5 years ago

Matthieu Schaller @matthieu started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Josh Borrow

Matthieu Schaller @matthieu started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Josh Borrow

Matthieu Schaller @matthieu started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Josh Borrow

Josh Borrow added 1 commit 5 years ago

added 1 commit

6dab5c63 - Fixed a bunch of find-replace cockups

Compare with previous version

Josh Borrow added 1 commit 5 years ago

added 1 commit

2e9c8847 - Fixed accidentally removed line in Makefile.AM

Compare with previous version

Josh Borrow @jborrow 5 years ago

Author Developer

Think I should have fixed all my cockups now

Josh Borrow resolved all discussions 5 years ago

resolved all discussions

Matthieu Schaller merged 5 years ago

merged

Matthieu Schaller mentioned in commit 5 years ago

mentioned in commit cddbc781

Please register or sign in to reply