[WIP] Blackhole gas swallowing
Merge request reports
Closed by
(May 29, 2025 5:41pm UTC)
Activity
added 51 commits
-
874646fa...11300e89 - 9 commits from branch
master - 5097f9e9 - Added debugging function to make sure all the particles tagged for swallowing…
- 6a79cdd3 - Added new BH->part interaction function to label particles to be swallowed.
- d3d3bc9f - Created the tasks required for the BH swallowing
- 367712fe - Added the task loop to decide which particle to swallow.
- 2fb3ac4d - Correctly reset the new task pointers to NULL
- c817754a - Do not swallow particles in the setting-up time-step.
- d5436feb - Also check for un-swallowed particles at the end of the 0th step.
- 4527b6d9 - Temporarily initialise the particles and BHs such that some swallowing actually happens.
- 2902c78f - Added tasks to properly remove the gas particles that have been swallowed.
- 775578a7 - Only construct BH tasks in cells that have black holes.
- 7f661956 - Also skip inhibited particles in the hydro loops when looping over active…
- a5e13052 - Correct typo in dependency graph script.
- 843d6f76 - The do_swallow() task should recurse only in the sub-cells that have been drifted.
- c37e71d7 - Make the swallowing code also work with Anarchy-PU
- 6920da1b - Create separate communication tasks for the different BH exchanges.
- f9a2fe1e - Added more communication task and their dependencies for the particle swallowing.
- 16e71cf7 - Skip the BH swallowing tasks in the very first engine_launch()
- 19b97891 - Black hole particles can swallow gas particles over MPI. Provided the gas…
- 6995445e - Better name for the swallowing-related BH communication tasks.
- d2c88c63 - Added a communication task for the gas particles marked as to-be-swallowed
- 579a4bcc - Working version of the swallowing on EAGLE-6 with and without MPI
- 01bed43e - Working version of the swallowing on EAGLE-6 with and without MPI
- b0f2e020 - Do not compute the BH feedback if the time-step is 0.
- 13175d32 - Recurse in the do_swallow() task to only consider the particles that may have been swallowed.
- 868ce9af - Make the swallow ghost tasks implicit.
- a409eb74 - Only activate the swallow communication tasks if the corresponding cell is active.
- d12f68f6 - Make the particles temporarily carry the ranks they live on.
- 95304254 - Temporarily make the swallowing tasks do nothing. Add locking/unlocking of the…
- b6eb67bb - Fix bracketing mistake following the rebasing.
- e949c652 - Create BH tasks in all cells, even the ones without BHs.
- 629975ca - Fixed the crash by cancelling the part_swallow communication.
- cc1fe299 - Added a dependency between the hydro/force and recv/part_swallow
- 7b87e2c4 - Re-instate the debugging checks that were temporarily cancelled.
- 6efd231a - Removed large commented-out chunk of code.
- 89171b9b - Added checks on the BH side to verify that they did swallow everything they should.
- b71784a0 - Use atomic operations to update the BH swallowing debugging counters.
- a77b836e - Created a simpler example to make progress on the BH swallowing problem.
- 0ad710c1 - Example now runs smoothly in the case of 1 gas particle and 2 BHs with one BH on…
- 9fa3927f - Moved back to analysing the EAGLE-6 example.
- a3297699 - Do not include partition cost file.
- 705264a9 - Create dependency to prevent sending the new Swallow-ID too early.
- 671991e2 - Use a separate communication buffer for the foreign swallow_ids.
Toggle commit list-
874646fa...11300e89 - 9 commits from branch
added 1 commit
- 1835500c - Do not include the partition_fixed_costs.h in the repository.
added 1 commit
- 3d887d1b - Mark the swallowed particles with a special tag to prevent double-swallowing.…
added 1 commit
- a3d031d3 - Mark the swallowed particles with a special tag to prevent double-swallowing.…
added 1 commit
- 139314b1 - Removed debugging code and clarified some new additions with documentation.
added 1 commit
- d896e5db - Make the code compile without debugging checks. Remove the global space pointer…
added 1 commit
- a7387dcd - Reduce the number of BH tasks by only creating them where the cells contain BHs.
added 1 commit
- 9edf57f1 - Moved the actual swallowing of the gas particles to the BH model sub-directory.
added 2 commits
added 70 commits
-
214eeae7...a3c1cc83 - 11 commits from branch
master - a5cec435 - Added debugging function to make sure all the particles tagged for swallowing…
- fd383a2f - Added new BH->part interaction function to label particles to be swallowed.
- 0cae55bd - Created the tasks required for the BH swallowing
- 0f48c264 - Added the task loop to decide which particle to swallow.
- 3566ddc5 - Correctly reset the new task pointers to NULL
- 97af0119 - Do not swallow particles in the setting-up time-step.
- cf13de4a - Also check for un-swallowed particles at the end of the 0th step.
- 5e9a2c88 - Temporarily initialise the particles and BHs such that some swallowing actually happens.
- 014f8500 - Added tasks to properly remove the gas particles that have been swallowed.
- 5b724c19 - Only construct BH tasks in cells that have black holes.
- 32e78200 - Also skip inhibited particles in the hydro loops when looping over active…
- 2997bfb1 - Correct typo in dependency graph script.
- cadc1554 - The do_swallow() task should recurse only in the sub-cells that have been drifted.
- 365b619c - Make the swallowing code also work with Anarchy-PU
- c4066b9e - Create separate communication tasks for the different BH exchanges.
- 6596fbaa - Added more communication task and their dependencies for the particle swallowing.
- 9554b7da - Skip the BH swallowing tasks in the very first engine_launch()
- 07841bbe - Black hole particles can swallow gas particles over MPI. Provided the gas…
- ff79b9dc - Better name for the swallowing-related BH communication tasks.
- 0f15c9c8 - Added a communication task for the gas particles marked as to-be-swallowed
- b9cc3f32 - Working version of the swallowing on EAGLE-6 with and without MPI
- 21be7cf8 - Working version of the swallowing on EAGLE-6 with and without MPI
- 0ea92a7f - Do not compute the BH feedback if the time-step is 0.
- 5bfc8e33 - Recurse in the do_swallow() task to only consider the particles that may have been swallowed.
- 2904393a - Make the swallow ghost tasks implicit.
- 1b6c97c1 - Only activate the swallow communication tasks if the corresponding cell is active.
- 855ed43f - Make the particles temporarily carry the ranks they live on.
- 948c09f1 - Temporarily make the swallowing tasks do nothing. Add locking/unlocking of the…
- fa9c50c6 - Fix bracketing mistake following the rebasing.
- 70ed92b1 - Create BH tasks in all cells, even the ones without BHs.
- 87dbc022 - Fixed the crash by cancelling the part_swallow communication.
- f97d9875 - Added a dependency between the hydro/force and recv/part_swallow
- 19b81552 - Re-instate the debugging checks that were temporarily cancelled.
- 6328c8c5 - Removed large commented-out chunk of code.
- 497821ce - Added checks on the BH side to verify that they did swallow everything they should.
- 98187243 - Use atomic operations to update the BH swallowing debugging counters.
- 1efbf9ac - Created a simpler example to make progress on the BH swallowing problem.
- e0374155 - Example now runs smoothly in the case of 1 gas particle and 2 BHs with one BH on…
- a948a712 - Moved back to analysing the EAGLE-6 example.
- 4491e345 - Do not include partition cost file.
- 796d9e92 - Create dependency to prevent sending the new Swallow-ID too early.
- 7d7fe970 - Use a separate communication buffer for the foreign swallow_ids.
- 8a33e45b - Do not include the partition_fixed_costs.h in the repository.
- fef6c180 - Mark the swallowed particles with a special tag to prevent double-swallowing.…
- 41b25252 - Mark the swallowed particles with a special tag to prevent double-swallowing.…
- 3770cd2b - Re-instate the repartition calls
- ebd28ba1 - Removed debugging code and clarified some new additions with documentation.
- a9dcba17 - More debugging code removed from the EAGLE black holes
- b085caf8 - Remove the debugging files. Lock the space only where needed when BHs swallow particles.
- 2f6ab528 - Make the task temporatily store a pointer to the task it is running. Helps with…
- b003b30b - Make the code compile without debugging checks. Remove the global space pointer…
- afc19936 - Reduce the number of BH tasks by only creating them where the cells contain BHs.
- 787f1344 - Clarify the BH communication activation
- e9b220e9 - Moved the actual swallowing of the gas particles to the BH model sub-directory.
- 938f896e - Removed debugging message in the unpacking of swallow IDs.
- 4a952d5c - Properly added the black holes swallow ghost task to delay the calculation of…
- 5aa1314e - Documentation fixes.
- d55d9006 - Give the correct task action to the BH-related tasks.
- ebd0061e - Added structures to be carried by the part for black holes purposes.
Toggle commit list-
214eeae7...a3c1cc83 - 11 commits from branch
added 1 commit
- b7f55bb1 - Moved the particle carried BH-fields to a separate structure.
added 1 commit
- 99a14b3c - Added the BH structure to all the hydro parts.
Please register or sign in to reply