Communication tasks for on-the-fly star formation

Allow star-formation in combination with stellar feedback over MPI. Specifically this involves:

• A new communication task propagating the counts of stars in cells that have created stars.
• A change in the unskipping strategy of star tasks. They need to be activated also in the case where the cell is only active for hydro purposes as that cell may form a star.

added 2 commits

• c4a9352b - When lisiting 'useful' top-level cells also check whether they have a black hole.
• 5ee42c0f - Added a function to check whether a given cell is starting its BH time integration on this step.

Compare with previous version

added 10 commits

• 5ee42c0f...9355dbdd - 9 commits from branch black_hole_tasks
• 6ad43f47 - Merge branch 'black_hole_tasks' into star_formation_mpi_comms

Compare with previous version

added 2 commits

• 515007da - Version that passes 3000+ steps on eagle-25
• d56d6820 - Correct colour for the SF communication tasks in the dependency graph script.

Compare with previous version

added 2 commits

• 0a3c05b8 - Free the sort arrays when clearing the unused sort flags in the sorts.
• 1eecba0a - Mode the SF count communication tasks to the top-level.

Compare with previous version

unmarked as a Work In Progress

changed target branch from black_hole_tasks to master

added 14 commits

• 1eecba0a...c35476c1 - 13 commits from branch master
• a60f41c6 - Merge branch 'master' into star_formation_mpi_comms

Compare with previous version

changed title from Star formation mpi comms to Communication tasks for on-the-fly star formation

added EAGLE label

changed milestone to %Paris

assigned to @pdraper

This is ready to go. It runs on the EAGLE boxes with MPI and the star-formation and feedback runtime flags switched on.

I need to clean up the debugging messages but wanted to give you an advanced warning that it is coming.

changed the description

added 2 commits

• 5c6692f8 - Improve error message in the EAGLE feedback routine.
• bf4e11b6 - Improved the sort flag cleaning function.

Compare with previous version

added 1 commit

• 838f353d - Documentation fixes. Removed debugging code.

Compare with previous version

added 2 commits

• a2cb036e - Better exit condition in cell_activate_subcell_stars_tasks() and cleaner documentation strings.
• e7a05329 - Removed more debugging code.

Compare with previous version

@pdraper This is ready to be scrutinized. Should allow to run with star formation, feedback and black holes all together over MPI.

added 1 commit

• 6ec5cfdf - No need to modify the EAGLE 12 and EAGLE 25 parameter files. The default values work well.

Compare with previous version

Thanks!

added 1 commit

• 0688ed88 - Correct typo in error message and forgotten debugging branch.

Compare with previous version

resolved all discussions

resolved all discussions

All looking good so far. The only thing I saw in my full EAGLE_50 test (with sanitizer and debug checks enabled, plus --cosmology --hydro --self-gravity --stars --black-holes --star-formation --feedback --cooling) was:

[0000] [01752.3] engine_init_particles: WARNING: found 1 gpart pairs at the same location. That is not optimal

this is with the latest ICs. Harmless, probably..?

That would be harmless, yes. Likely a black hole at the same place as something else in the new ICs.

All looks good to go. Ready from your end?

That's good for me, yes. Great to see this eventually done.

merged

mentioned in commit b993f2c5

Good, so black-hole formation next...