Implementation of black hole accretion and feedback

Adds the following:

• self/pair tasks for the black holes
• MPI communication tasks for the black holes
• A new black holes properties structure to contain the BH model details
• New type of black holes for the EAGLE model
• Bondi + Eddington accretion model for the EAGLE AGN model
• Update to the yaml parameter files for the new parameters
• Update to the python analysis scripts
• Update to the low-z ICs to contain black hole smoothing lengths.

@dc-bahe1 feel free to comment here if you find something odd with the BH physics.

added 1 commit

• 6c14d08b - Added MPI tasks for the BH density and feedback.

Compare with previous version

added 1 commit

• aaebdc2b - Correctly report the number of black hole particles read from the ICs.

Compare with previous version

added 1 commit

• b0abb472 - Correctly gather the black holes' h_max when rebuilding.

Compare with previous version

added 1 commit

• e6000ae7 - Also take the BH kernel size into account when splitting the hydro tasks.

Compare with previous version

added 1 commit

• c8534de8 - Added restarting facility to the AGN model.

Compare with previous version

added 1 commit

• 9411d324 - Updated the EAGLE-low z examples to have smoothing lengths for their black holes.

Compare with previous version

changed the description

added 1 commit

• 3ae1dece - Removed the overwriting of the BHs h in the EAGLE-6 example.

Compare with previous version

assigned to @pdraper

This is ready to be tested. We get new tasks when running with --black-holes. I have run it on all the EAGLE low-z examples with and without MPI. The physics is tested and validated elsewhere.

Hopefully I did not break anything else while doing so.

Note that I have re-generated the ICs to include smoothing lengths for the BHs. They need to be re-downloaded for testing.

I will rebase onto !790 (merged) once merged.

(sorry for the monster push...)

added 1 commit

• 3963ed0e - Call MPI_abort and not swift_abort when crashing.

Compare with previous version

added 1 commit

• 264f2489 - Give correct weights to the BH-related tasks.

Compare with previous version

added 51 commits

• 264f2489...e21885b1 - 17 commits from branch master
• 81a132f0 - Added neighbour finding loops for the black holes and infrastrcture to create the tasks.
• 0501d3aa - Added the ghost task for black holes.
• 8e057a9d - Created the drift and ghost tasks for the black holes.
• f898d54d - Updated the plotting python scripts to include the new BH-related tasks.
• b7e42cf5 - Added the self tasks for the black holes
• ff5d4a08 - Added the pair and sub tasks for black holes
• 3bfd0dea - Don't let the code start if the black hole smoothing lengths are 0
• 25c56840 - Activate all the necessary BH tasks in engine_marktasks().
• 6713c025 - Also update the task unskipping code for the new BH tasks.
• 3e4ede57 - Added file infrastructure for the EAGLE black hole model.
• 7b435d77 - Added calculation of the Bondi rate in the EAGLE AGN feedback model.
• 95e3d466 - Limit the accretion rate of EAGLE black holes to a fraction of the Eddington rate.
• be216e98 - Removed incorrect documentation string in the EAGLE feedback model.
• 03c8026b - Read the properties of the EAGLE AGN model from the parameter file.
• 5ce16cce - Added BH formation time to the BH particles. Added many BH properties to the i/o.
• a0db7da4 - Added instantaneous accretion rate to the EAGLE BH snapshots. Compute the…
• e33ed64a - Added calculation of the AGN feedback energy to distribute and probability to do so.
• 22082da2 - Optionally read the energy reservoir values from the ICs. Can be useful for debugging tests.
• dd723293 - Added the injection of energy into the gas particles from AGN feedback.
• 28344b91 - Added the deduction of energy from the reservoir when AGN feedback happens.
• 852c89e1 - Also make the code compile with the new function signatures if we are not using…
• 5d17d400 - Updated the EAGLE parameter files and the master parameter file for the new AGN-related parameters.
• 447086d3 - Doxygen documentation fixes.
• e7b9d012 - Added MPI tasks for the BH density and feedback.
• fbec5a0f - Correctly report the number of black hole particles read from the ICs.
• bc279065 - Correctly gather the black holes' h_max when rebuilding.
• ff27fd81 - Also take the BH kernel size into account when splitting the hydro tasks.
• 1b5ccf58 - Added restarting facility to the AGN model.
• 065e86f7 - Updated the EAGLE-low z examples to have smoothing lengths for their black holes.
• d3356f13 - Removed the overwriting of the BHs h in the EAGLE-6 example.
• 5e4f97d8 - Call MPI_abort and not swift_abort when crashing.
• f2983c34 - Give correct weights to the BH-related tasks.
• 93f1372e - Activate the BH drift and not the star drift for the BH pair tasks.
• 77206f9a - Updated the send/recv unskipping to use the new linked lists.

Compare with previous version

added 2 commits

• b87a3194 - Better default guess for the number of links per tasks.
• 92d0f081 - Added the total accreted gas mass of a black hole to the EAGLE output.

Compare with previous version

@dc-bahe1 that last version should fix your problem.

added 1 commit

• 67661f0e - Fixed typo in the unskipping of black hole communications.

Compare with previous version

@pdraper I think this is now all merged and fine.

added 1 commit

• 35dc7147 - Added missing communication tasks in the analysis scripts.

Compare with previous version