Skip to content
Snippets Groups Projects

Star formation sub grid update

Merged Folkert Nobels requested to merge SF_update into master

I changed the temperature criteria to an entropy criteria to be faster, furthermore I added the birth temperature to the snapshots and added a histogram plot to the solutions.

So I run tests using the lowres8 isolated galaxy without feedback, and I don't seem to see any difference in the results: Old: KS_law New: KS_law

Same for the SFH: Old: SFH_all New: SFH_all

I will run the one with feedback to check if it gives a similar result.

One thing, I assumed that in general we want to keep the functionality to call the cooling function in star_formation_is_star_forming function for other subgrid models, so that function still has the required arguments.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading