No cooling limit

Multiple changes:

• Remove the Newton cooling scheme from the main cooling track.
• Fix the cooling from Iron.
• Do not set a maximal du/dt taking into account the increase in time-step size.
• Check the entropy floor in the drift and kick.
• Recompute the pressure and sound-speed after the floor has been applied.

2 questions for @jborrow on this:

• Can you cross-check I did not break anything?
• I can't see why we need a cosmo->a_factor_sound_speed term in the expression for alpha_diff_dt

For the second comment, it's included because you've got a factor of sqrt(u) that transforms as a sound-speed, and we want to do these calculations in physical space.

That is, unless I'm missing something?

Oh ok. Yes, that makes sense. I had misread the comment then and then made it worse in my version.

added 2 commits

• 61af330b - Applied code formatting to the newton eagle cooling.
• d07b2d17 - Fix compilation in the case without EAGLE model.

Compare with previous version

changed the description

added 3 commits

• aa7d8482 - Minor style improvements.
• 293c6ca0 - Better choice of softening length for the isolated galaxy with feedback example.
• b0cb3801 - Merge branch 'no_cooling_limit' of gitlab.cosma.dur.ac.uk:swift/swiftsim into no_cooling_limit

Compare with previous version

added 2 commits

• 51dc2a33 - Also update the Planetary SPH for the new signature.
• 8962d241 - Update the Anarchy scheme to check for the floor at the drift and kick

Compare with previous version

@jkeger Could you check that this did not break your tests? I have changed the way we apply the minimal temperature/energy in the time integration.

@jborrow if you have time could you run the hydro suite on Minimal, Gadget and anarchy to check that nothing has been broken here?

added 16 commits

• 8962d241...7709d4a2 - 15 commits from branch master
• 87564b26 - Merge branch 'master' into no_cooling_limit

Compare with previous version

added 1 commit

• 11f3db6d - Documentation fixes.

Compare with previous version

added 1 commit

• 42cb1b4d - Updated the other hydro schemes with the new kick/drift signatures.

Compare with previous version

merged

mentioned in commit 75292312

Bit late but seems fine for me!