Eagle stellar evolution (!781) · Merge requests · SWIFT / SWIFTsim · GitLab

Snippets Groups Projects

Closed Alexei Borissov requested to merge eagle-stellar-evolution into master 6 years ago

Merge request for feedback based on EAGLE subgrid physics.

Edited 6 years ago by Matthieu Schaller

Activity

Matthieu Schaller unmarked as a Work In Progress 6 years ago

unmarked as a Work In Progress
Matthieu Schaller added EAGLE enhancement feature request labels 6 years ago

added EAGLE enhancement feature request labels
Matthieu Schaller added 1 commit 6 years ago
added 1 commit

cebee5d5 - Applied code formatting tool.

Compare with previous version
Matthieu Schaller @matthieu 6 years ago

Owner

Can you remove the debugging code? for instance the print messages in the engine or the commented-out code in the interaction functions.

Also, what tests would you recommend I run to verify that all is fine?
Matthieu Schaller @matthieu started a thread on an old version of the diff 6 years ago

Resolved 6 years ago by Matthieu Schaller
Last reply by Alexei Borissov 6 years ago

Matthieu Schaller @matthieu started a thread on an old version of the diff 6 years ago

Resolved 6 years ago by Matthieu Schaller

Matthieu Schaller @matthieu started a thread on an old version of the diff 6 years ago

Resolved 6 years ago by Matthieu Schaller

Matthieu Schaller @matthieu started a thread on an old version of the diff 6 years ago

Resolved 6 years ago by Matthieu Schaller

Matthieu Schaller @matthieu started a thread on an old version of the diff 6 years ago

Resolved 6 years ago by Matthieu Schaller

Matthieu Schaller @matthieu started a thread on an old version of the diff 6 years ago

Resolved 6 years ago by Matthieu Schaller

Matthieu Schaller @matthieu started a thread on an old version of the diff 6 years ago

Resolved 6 years ago by Matthieu Schaller

Matthieu Schaller @matthieu started a thread on an old version of the diff 6 years ago

src/runner.c

         /* Copy the minimum into the new sort array. */
         finger[ind].d = buff[inds[0]];
         if (c->progeny[inds[0]] == NULL ||
             c->progeny[inds[0]]->stars.count == 0)
           error("should not do it");

Alexei Borissov added 1 commit 6 years ago

added 1 commit

15790593 - removed debugging print statements

Compare with previous version

Alexei Borissov added 1 commit 6 years ago

added 1 commit

d1824f60 - add isolated galaxy feedback example

Compare with previous version

Alexei Borissov added 1 commit 6 years ago

added 1 commit

422568ad - remove change to mandatory parameters in yml file for feedback

Compare with previous version

Alexei Borissov added 1 commit 6 years ago

added 1 commit

c7f5a201 - update parameter_example file to reflect feedback parameters

Compare with previous version

Alexei Borissov added 1 commit 6 years ago

added 1 commit

89b6ae77 - change to const struct spart in signature of runner_iact_nonsym_stars_feedback

Compare with previous version

Alexei Borissov added 1 commit 6 years ago

added 1 commit

20a24826 - moved computation of heating probability and energy change out of loop over particles

Compare with previous version

Alexei Borissov added 1 commit 6 years ago

added 1 commit

d2e9176e - changed definition of Gyr_to_cgs

Compare with previous version

Alexei Borissov added 1 commit 6 years ago

added 1 commit

8edf2354 - removed debugging code

Compare with previous version

Please register or sign in to reply