Skip to content
Snippets Groups Projects

Add EOS temperature from entropy floor

Merged Folkert Nobels requested to merge EAGLE_EOS into master
All threads resolved!

This merge request fixes a difference we implemented differently in SWIFT as compared to EAGLE. Instead of calculating the EOS temperature from the star formation EOS we need to calculate this from the entropy floor, this merge request does that. I also have run the idealized disk without problems, it produces the same result. threshold density (numb/cm^3) is around 0.03 for solar, that still has a temperature above the threshold given by around (0.03/0.1)^(1/3)8000 K10^.5 = 17000 K, so in the case of my disk, it produces exactly the same result as before. Any comments on the code?

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Matthieu Schaller
  • Folkert Nobels added 4 commits

    added 4 commits

    • 25b5549c - Rename entropy to entropy_floor in runner
    • cf2f6f27 - Rename entropy to entropy_floor in the star_formation.h files
    • 1583fa08 - Add comment to the Entropy floor
    • 25037693 - Add function documentation to the new function

    Compare with previous version

  • Folkert Nobels added 1 commit

    added 1 commit

    Compare with previous version

  • Folkert Nobels resolved all discussions

    resolved all discussions

  • Author Contributor

    @matthieu, thanks for the feedback I implemented it.

  • added 1 commit

    • 9bf58bcd - Applied code formatting tool and explicitely documented the fact that the EAGLE…

    Compare with previous version

  • mentioned in commit 79f3e9a0

  • Please register or sign in to reply
    Loading