Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • SWIFTsim SWIFTsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 57
    • Issues 57
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 21
    • Merge requests 21
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • SWIFT
  • SWIFTsimSWIFTsim
  • Merge requests
  • !750

Stars use sort

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Loic Hausammann requested to merge stars_use_sort into master Feb 28, 2019
  • Overview 14
  • Commits 13
  • Changes 3

In this branch, I am optimizing the dopair functions for the stars. They are about 100 times faster than the previous version on EAGLE_6. The global speedup is about 2x.

I discovered a bug in the optimized version of the hydro. Here https://gitlab.cosma.dur.ac.uk/swift/swiftsim/blob/master/src/runner_doiact.h#L1003 we cannot use this exit condition. hi_max is not always the max, therefore we can skip a few particles (quick estimation of about 1 missed neighbors every 10'000 particles).

I am not solving it yet (will be in a separate merge request), but the stars are not reproducing this error. Due to this error, the stars sort is not as useful as expected, therefore I am also removing the sorts.

@matthieu, I am also fixing a few checks from your branch.

Currently I am requesting to merge with mpi_stars2_matthieu, but we can wait a bit longer and do it directly to the master.

Edited Mar 14, 2019 by Matthieu Schaller
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: stars_use_sort