Grackle cosmo

Update the grackle cooling in order to work with the cosmology.

The coolingbox example is also updated. In order to be more intuitive, I moved from energies toward temperatures.

Here is the SmallCosmoVolume_cooling with grackle:

added 1 commit

• 97afaad9 - Update list cooling

Compare with previous version

What do you mean by you moved from energies towards temperatures?

added 1 commit

• 7749c5f3 - coolingbox: Use Agg

Compare with previous version

@aborissov can you check that the updates to the python scripts do not break the coolingobx example for your EAGLE cooling?

I think that energies are not very meaningful. E.g. I have absolutely no idea what an energy of 1e4 erg means, but a temperature of 1e3 K is a lot more meaningful. Therefore I transformed all of the energies into equivalent temperatures. I am obtaining the following graph with Grackle.

The more tricky aspect is that the u->T conversion depends on some assumptions. Ionisation state for instance and metal content.

I agree. Here I am assuming no ionization, metals. Maybe we can find a notation where it does make sense.

Radiated energy in Kelvin and adding a description in the README?

Looks like it works for me. One note, I needed to change the number of snapshots read by plotTemperature.py as it was trying to read more than was produced.

added 1 commit

• f03bee4c - CoolingBox: improve labels

Compare with previous version

Here is an updated version. I am keeping the temperature "units", but now I explicitly write them in the labels.

I am also reading the number of snapshots in the script in order to avoid alexei's problem.

added 1 commit

• 39d44213 - CoolingBox: Read number of snapshots

Compare with previous version

Thanks both. Good that the script remains flexible.

All good to merge? Or would you like to solver the energy wiggles problem?

All good to merge. I think the wiggle problems is not important for the physics (the internal energy line does not wiggle).

added 1 commit

• 0e1a4b5b - Applied code formatting tool.

Compare with previous version

added 1 commit

• 651a2cdc - Move plotTemperature to plotEnergy

Compare with previous version

added 1 commit

• 507025c1 - Remove a global variable

Compare with previous version

resolved all discussions

merged

mentioned in commit 95a3b79f