WIP: Move configure to m4
@matthieu: After a discussion with @pdraper, the simplest approach is to define m4 macros and just copy/paste them in PySWIFTsim.
In this merge request, I am just splitting configure.ac
in multiple files. I will deal with PySWIFTsim in a later merger request.
By the way, we cannot expand AC_PROG_FC
multiple time in a macro (required for velociraptor and grackle). The simplest approach was to have this requirement in every cases and not only with velociraptor/grackle. From my experience, fortran is still available on every linux computer.
Merge request reports
Activity
added 18 commits
-
ba1b401a...8e70ca0d - 16 commits from branch
master
- 4e560f93 - Split configure in multiple subfiles
- 90038dec - Add gravity
-
ba1b401a...8e70ca0d - 16 commits from branch
I am not sure what went wrong with jenkins https://gitlab.cosma.dur.ac.uk/jenkins/job/SWIFT%20merge%20requests/1469/console
It seems that we should have
mt_mpi
in this case.Exactly, in this way I can just re-use the macro in PySWIFTsim's
configure.ac
.In SWIFT, I will try to add PySWIFTsim as a submodule and include its
configure.ac
in SWIFT's one (it should be easy, I have done some quick test). Therefore when you configure/compile SWIFT, you will be able to configure/compile PySWIFTsim at the same time.I think it is also nice to split a bit
configure.ac
, this file was starting to become too huge.This seems like more of a change than I expected. Nice and tidy, but I suspect we have lost some necessary orderings to do with when MPI compilers and the warning flags are defined, for instance, so some or maybe all of the
special
flags macro may need to be migrated back or further divided. Made WIP until I get some time to look at this closely.