Skip to content
Snippets Groups Projects

Implement feedback loop

Merged Loic Hausammann requested to merge implement_feedback_loop into master
All threads resolved!

@aborissov I have implemented the feedback functions in this merge request. If you have any question about it, I am always available on slack. I have also pushed my SedovBlast_3D example with a star at the center in order to generate the blast. You will still need to implement the task dependency and default feedback scheme.

@matthieu nothing fancy here. I am just applying the runner_doiact.h trick to runner_doiact_stars.h, removing the timers and pushed my example that consists mainly in a copy/paste of SedovBlast_3D.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Just to clarify something, the loops are both the same and are of "type 1". Am I reading this correctly?

  • Yes you are

  • Should I change the names to DOPAIR1 in order to show the type explicitly?

  • added 1 commit

    Compare with previous version

  • Matthieu Schaller resolved all discussions

    resolved all discussions

  • Sorry, I had overlooked your question. Now that you mention, it, yes I think it's a good idea. Better to be clear about these things.

  • @aborissov can you confirm that this branch all makes sense?

  • added 1 commit

    • b2abe0af - change pair -> pair1 in doiact_stars

    Compare with previous version

  • I changed my PAIR to PAIR1 and SELF to SELF1 but only in runner_doiact_stars.h.

  • Yes, perfect. Thanks!

  • added 1 commit

    • 0f75012d - Update number of task for stars

    Compare with previous version

  • Just for the record, this looks good to me.

  • Matthieu Schaller
  • Matthieu Schaller resolved all discussions

    resolved all discussions

  • added 1 commit

    Compare with previous version

  • Thanks! All good.

  • mentioned in commit fbd9f1e3

  • Please register or sign in to reply
    Loading