Skip to content
Snippets Groups Projects

Sorts bug fix

All threads resolved!
Merged Matthieu Schaller requested to merge sorts_bug_fix into master
All threads resolved!

Fixes #488 (closed).

This possibly fixes an old bug that would seldomly lead to unsorted cells in the pair interactions. #488 (closed) was the first time I could catch it in an easily reproducible scenario.

Does the fix in the recursion of runner_do_sort() make sense to you as well? The idea is that we set the sort flag in the unskip based on the old value of dx_max_part so we should use that same value here and not the one obtained after the drift that just happened.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loic Hausammann resolved all discussions

    resolved all discussions

  • Loic Hausammann mentioned in commit 46410b87

    mentioned in commit 46410b87

  • Loic Hausammann mentioned in commit 2a805a92

    mentioned in commit 2a805a92

  • Peter W. Draper mentioned in commit dfeb0527

    mentioned in commit dfeb0527

  • Please register or sign in to reply
    Loading