Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • SWIFTsim SWIFTsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 52
    • Issues 52
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 17
    • Merge requests 17
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • SWIFT
  • SWIFTsimSWIFTsim
  • Merge requests
  • !676

Sorts bug fix

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Matthieu Schaller requested to merge sorts_bug_fix into master Nov 15, 2018
  • Overview 6
  • Commits 2
  • Changes 2

Fixes #488 (closed).

This possibly fixes an old bug that would seldomly lead to unsorted cells in the pair interactions. #488 (closed) was the first time I could catch it in an easily reproducible scenario.

Does the fix in the recursion of runner_do_sort() make sense to you as well? The idea is that we set the sort flag in the unskip based on the old value of dx_max_part so we should use that same value here and not the one obtained after the drift that just happened.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: sorts_bug_fix