Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • SWIFTsim SWIFTsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 53
    • Issues 53
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 17
    • Merge requests 17
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • SWIFT
  • SWIFTsimSWIFTsim
  • Merge requests
  • !660

Make mpicollectgroup1_reduce() loop over all the elements as described by the MPI standard.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Matthieu Schaller requested to merge correct_MPI_reduce into master Nov 04, 2018
  • Overview 1
  • Commits 1
  • Changes 1

I was looking at the implementation of a reduce operation over MPI for the multipoles and I stumbled upon this.

If my reading of section 5.9.5 of the MPI standard is correct then I think we need a loop over both the vectors passed into this function and not just the in one. Since we are doing a reduce of len 1 here, it likely makes no difference I'd better be safe here and use the recommended signature. What do you think?

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: correct_MPI_reduce