Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • SWIFTsim SWIFTsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 52
    • Issues 52
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 17
    • Merge requests 17
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • SWIFT
  • SWIFTsimSWIFTsim
  • Merge requests
  • !641

Fixes to the cosmo hydro

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Matthieu Schaller requested to merge fix_santa_barbara into master Oct 19, 2018
  • Overview 8
  • Commits 13
  • Changes 12

A bunch of all-around fixes that allow SWIFT to match exactly Gadget-2 on the SamllCosmoVolume hydro test.

This includes:

  • Restore the testSymmetry to its old glory.
  • Use the correct power of the scale-factor in the term designed to prevent numerical crashes in the Balsara switch.
  • Add a Hubble flow term to the Balsara switch in the Minimal & Gadget schemes.
  • Add the Hubble flow term to the viscosity SPH equation for the thermodynamic variable in the Gadget and Minimal schemes.
  • Document properly that the minimal energy stored in the hydro properties is in the physical frame.
  • Use the z=0 critical density when deciding the displacement of particles in space_generate_gas().
  • Correct a sign mistake in the displacement of generated gas particles.
Edited Oct 19, 2018 by Matthieu Schaller
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix_santa_barbara