Skip to content
Snippets Groups Projects

Split stars

Merged Loic Hausammann requested to merge split_stars into master

I have implemented the functions to recurse/split the stellar density tasks.

You will also find two new examples (feel free to remove them from the branch if you do not want them). The first one is a typical zoom in cosmological simulation done with GEAR and the second one is a galaxy extracted from the zoom in simulation. As the current star density task is very very slow, I need a smaller example to run a few steps.

I have also a new function in the scheduler that write down the depth of each task in a file. I used it to generate the graphs in the tasking channel of slack. Again feel free to remove the commit if you do not want it.

dependency_graph

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    Compare with previous version

  • I think that my next step will be to sort the stars in order to speedup the stellar functions.

  • Thanks, I will have a look.

    Before speeding things up, it could be worth checking that it is worth doing so.

  • In my DwarfGalaxy example, I used the plot_tasks.py script to see a bit and I am taking 5-10 times more time in the star density than in the hydro one.

  • Is that because the tasks are not split?

  • Maybe. I am splitting some of the task (you can see it in the dependency graph). But I do not really know how deep I go. That is why I tried to make the graph in the tasking channel.

    I still need to improve my graph to make it more explicit.

  • added 1 commit

    Compare with previous version

  • Loic Hausammann added 39 commits

    added 39 commits

    Compare with previous version

  • Matthieu Schaller
  • added 1 commit

    Compare with previous version

  • Matthieu Schaller
  • Matthieu Schaller
  • added 1 commit

    Compare with previous version

  • Looking at the code right now. Nice stuff!

    Two small comments:

    • Could we have README files for the the two new examples that just briefly describe what they are? See the Santa Barbara or small cosmo volumes.
    • I have also left a few remarks in the code.
  • I do not have time today, but should be done by tomorrow evening

  • added 1 commit

    • f56d6dea - Add readme for DwarfGalaxy and ZoomIn

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading