Skip to content
Snippets Groups Projects

Resolve "Separate the hand-written vectorization and the auto-vectorization flags"

Merged Resolve "Separate the hand-written vectorization and the auto-vectorization flags"
465-separate-the-hand-written-vectorization-and-the-auto-vectorization-flags into master
1 unresolved thread
Merged James Willis requested to merge 465-separate-the-hand-written-vectorization-and-the-auto-vectorization-flags into master
1 unresolved thread

Closes #465 (closed)

Edited by Matthieu Schaller

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
configure.ac
359 368 else
360 369 AC_MSG_WARN([Do not know how to disable vectorization for this compiler])
361 370 fi
362 else
371 elif test "$enable_hand_vec" = "yes"; then
363 372 AC_DEFINE([WITH_VECTORIZATION],1,[Enable vectorization])
  • Matthieu Schaller
    Matthieu Schaller @matthieu
    Owner

    Shouldn't --disable-vec disable the hand-vec as well?

  • Matthieu Schaller
    Matthieu Schaller @matthieu
    Owner

    Something like:

    if optimization:
   Add general optimization flags
   if vec:
       Add simd flags
       if hand-vec:
           Add the define
       endif
   endif
endif
    Edited by Matthieu Schaller
  • James Willis
    James Willis @jwillis
    Author Guest

    --disable-vec already disables hand-written vectorisation.

  • James Willis added 1 commit

    added 1 commit

    Compare with previous version

  • Matthieu Schaller
    Matthieu Schaller @matthieu
    Owner

    Ah, yes. All good, I had misread the logic.

  • Matthieu Schaller unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Matthieu Schaller assigned to @pdraper

    assigned to @pdraper

  • Matthieu Schaller
    Matthieu Schaller @matthieu
    Owner

    I'll assign to Peter for a final check.

  • Peter W. Draper
    Peter W. Draper @pdraper
    Owner

    Seems to do the right things, so accepting.

  • Peter W. Draper merged

    merged

  • Peter W. Draper mentioned in commit d9fd1872

    mentioned in commit d9fd1872

    • Please register or sign in to reply