Add testFormat

Here is an implementation of a unit test checking if swift is well formatted.

I decided to improve the format.sh script and just call it from a test script (simplify any future modifications of the format)

Thanks for implementing this!

Looks good to me, but I can't test it myself right now, so punting to @pdraper.

assigned to @pdraper

Well the obvious issue is that it requires the external command clang-format-5.0 to be available. Perhaps we should make it gracefully handle the lack of this command (hint command -v clang-format-5.0)?

The problem with pipes is that they eat exit statuses, so you need to add "set -e" at the top of this script. Otherwise if "$cmd" fails you only see the exit status of "grep".

changed this line in version 3 of the diff

added 1 commit

• 8ec2da6a - Add testFormat

Compare with previous version

I am now using command and set -e. Thanks for the suggestion :)

added 1 commit

• b82b6e1a - Handle pipe errors more explicitly, failing at first command in the pipe was OK…

Compare with previous version

Thanks, on second thoughts the set -e was no good when using format.sh -t interactively, so I've added some more painful bash-isms to handle this. We also need to use a different command on COSMA (the command is clang-format, regardless of version), so you can use an environment variable to change that.

Please check this all. If OK I'll accept.

Everything seems to work on my computer. I am fine with your modifications.

Hopefully Jenkins is setup for this, so going to accept and see what happens.

merged

mentioned in commit ec56acb4