Skip to content
Snippets Groups Projects

Gizmo mfm clean

Merged Gizmo mfm clean
gizmo_mfm_clean into master
1 unresolved thread
Merged Bert Vandenbroucke requested to merge gizmo_mfm_clean into master
1 unresolved thread

Removed unnecessary variables to make Gizmo MFM more lightweight. Cleaned up the code.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
src/riemann/riemann_hllc.h
33 33 #include "riemann_checks.h"
34 34 #include "riemann_vacuum.h"
35 35
36 #ifndef EOS_IDEAL_GAS
37 #error \
38 "The HLLC Riemann solver currently only supports and ideal gas equation of state. Either select this equation of state, or try using another Riemann solver!"
39 #endif
  • Bert Vandenbroucke
    Bert Vandenbroucke @bvandenbroucke
    Author Developer

    Yes, it can. Nowadays we just ignore the energy for an isothermal EoS, so there's no need to use a dedicated isothermal solver anymore. I don't think it will break if I just remove this line.

  • Bert Vandenbroucke
    Bert Vandenbroucke @bvandenbroucke
    Author Developer

    Going through the code, it looks like I already removed it anyway. So yes, it can be dropped.

  • Matthieu Schaller merged

    merged

  • Matthieu Schaller mentioned in commit e1d0f0d2

    mentioned in commit e1d0f0d2

    • Please register or sign in to reply