Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • SWIFTsim SWIFTsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 52
    • Issues 52
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 17
    • Merge requests 17
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • SWIFT
  • SWIFTsimSWIFTsim
  • Merge requests
  • !577

Fix parser

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Loic Hausammann requested to merge fix_parser into master Jul 26, 2018
  • Overview 21
  • Commits 8
  • Changes 3

Fixes #445 (closed).

I am using a new variable in the parameter structure (is_default) that I set to 1 if we write in params a default value.

Currently I am only checking on the get_opt_params function. I am wondering if we should ensure that we are not reading a mandatory parameter from a default value.

For example:

parser_get_opt_param_double(params, "Test:test", 1.); // Test:test does not exist in params
parser_get_param_double(params, "Test:test"); // Here currently we read the previous default value without any warning

Any suggestion @pdraper, @matthieu?

Edited Aug 01, 2018 by Matthieu Schaller
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix_parser