Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • SWIFTsim SWIFTsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 57
    • Issues 57
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 21
    • Merge requests 21
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • SWIFT
  • SWIFTsimSWIFTsim
  • Merge requests
  • !567

[WIP] Add Pressure-Energy with Morris and Monaghan artificial viscosity

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Josh Borrow requested to merge add-morris-and-monaghan into master Jun 28, 2018
  • Overview 29
  • Commits 13
  • Changes 16

This includes a new scheme, pressure-energy-monaghan that includes a variable artificial viscosity.

More information is available here: http://adsabs.harvard.edu/abs/1997JCoPh.136...41M

This still needs documenting fully, but I think it is probably a good idea to merge this sooner rather than later to avoid divergence.

Note that we actually update the artificial viscosity half a time-step too "late" -- this does not seem to have a significant effect.

This passes all of the current hydro tests, and shows a significant improvement, particularly with respect to the width of the distributions.

See attached the SedovBlast_3D.

pressure-energy-monaghan_SedovBlast_3D_5_3D

One minor issue is that this makes performance on the Evrard collapse marginally worse; the distribution is moved around a bit.

pressure-energy-monaghan_EvrardCollapse_3D_8_3D

Edited Jul 07, 2018 by Matthieu Schaller
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: add-morris-and-monaghan