Output time from a file

@matthieu, If you wish to already review feel free, I will only modify cosmology_get_scale_factor in order to read from a table.

Everything else is implemented and ready to use.

Test I have done:

• Run SedovBlast_3D with output_list for snapshots and stats and checked the output times.
• Run partially SedovBlast_3D and restarted.
• Run CoolingBox with cosmology and checked the transformation redshift->scale_factor and time->scale_factor.

added 2 commits

• d941b7e1 - Use interpolation table for cosmology_get_scale_factor
• 516c0bbc - Add new test for cosmology

Compare with previous version

added 2 commits

• 0a4fdcbc - Set tolerance testCosmology to a reasonable value
• 5b3ab7c5 - Change output testCosmology and add warning message about accuracy in cosmology.c

Compare with previous version

added 1 commit

• 9c573808 - Remove unused struct declaration

Compare with previous version

#432 (closed) is now implemented (and I am happy with it). It just miss the fof and velociraptor parts but we will need them to be implemented first.

unmarked as a Work In Progress

added 1 commit

• 98ae2e10 - Add additional parameter for outputlist

Compare with previous version

added 244 commits

• 98ae2e10...dfa9f848 - 224 commits from branch master
• 18dfd24d - Add snaplist parameter
• 9eec034d - Add cosmological function between a and z
• 9f24e0ca - snaplist: add transformation between units (in progress)
• e0527d57 - Add function giving scale factor from time
• 8798607a - Snaplist: last transformation implemented
• cc37819d - Split common_io and snaplist
• 81339549 - Add snaplist restart
• 048fe3bf - add a new check for next output time
• 05e5d880 - Moved snaplist to outputlist and fixed restart
• 6992baa5 - Add new parameters in parameter_example.yml
• 90bd6e77 - Add doc for outputlist
• b7bf6574 - Modify parameter from outputlist to output_list
• 6e1ae480 - Improve comment for output_list
• 8c1ad6b4 - Use interpolation table for cosmology_get_scale_factor
• 3911ea38 - Add new test for cosmology
• 898beee7 - Set tolerance testCosmology to a reasonable value
• 14e947b8 - Change output testCosmology and add warning message about accuracy in cosmology.c
• 7bbfa7ad - Remove unused struct declaration
• 0005795b - Add additional parameter for outputlist
• 9fe66c10 - Fix rebasing error

Compare with previous version

I have rebased this branch. Everything is ready to be merged.

Thanks @lhausammann. I have left some comments on the diff.

Maybe @pdraper has some comments to make on the i/o aspects of this as well.

assigned to @matthieu

assigned to @pdraper

One obvious question. The examples only show a small number of output times, so is it necessary to have an external file? We can now accept an array of values, up to the length of a parameter string.

It depends on the number of snapshots required. But usually, you will need to write about a few hundred lines.

I was too lazy to write more lines (and I think it is not useful). If you wish, I can add more lines.

EAGLE had 400 outputs. Not regularly spaced.