Add master option for subgrid model

Implements #422 (closed).

added 1 commit

• f7a59a00 - Config: subgrid write correctly in config.h

Compare with previous version

Just saw that, sorry. :)

For EAGLE, we will need the EAGLE cooling and EAGLE chemistry for now and some hydro scheme that still needs finishing....

added 1 commit

• 0281546a - Add EAGLE master option

Compare with previous version

Ok done. My merge request is ready

Thanks. I'll wait until the other merge request related to the configuration step is accepted.

assigned to @matthieu

changed title from add master option to Add master option for subgrid model

changed the description

added Configuration label

merged

mentioned in commit 522c50e9

mentioned in commit 0433dea3

Ok. I had to revert this.

There was a typo in the switch that prevents compilation. But even with that fixed, the configuration script fails if I try ./configure --with-subgrid=gear or ./configure --with-subgrid=EAGLE. Something is incorrect in the logic when trying to select a hydro scheme.

See the branch subgrid_master_option.

I am not able to reproduce your bug. Can you send me the error message? Which version of autoreconf are you using? I am using the 2.69

By the way, with gear, you will need grackle v3.1

I do not want to mess with your branch, therefore here is a small comment fix (just before dealing with the subgrid option in configure.ac:

# Subgrid options
# if you add a restriction (e.g. not cooling, chemistry or hydro)
# you will need to check for overwrite after reading the parameter
# see the cooling AC_ARG_WITH for an example.

Ok. So I am not sure what happened with the test server. Might be a missing autoreconf or something.

Seems all good now. Can I make the change gear --> GEAR throughout the code?

Yes you can