Backup of restart files

Backup the restart files before overwriting. Meant to avoid issues with trucations for various reasons, like job being killed in the middle of the update.

The technique is just to check if the file already exists and move to a ".prev" version.

As discussed at the last telecon, I'm sitting on the checksum idea, but we may as well have this important update.

added 21 commits

• 7e23e02a...5a8eabba - 20 commits from branch master
• fa9e0e3a - Merge remote-tracking branch 'origin/master' into restart-structs

Compare with previous version

changed the description

Safety question: Is it worth first doing an rm on all the .prev files before starting the renaming procedure? Such that if things fail at the stage of renaming, we have a complete set (albeit with mixed names)?

added 1 commit

• 1dc820a7 - Unlink all the saved files before creating new ones. Avoids issues if the saves…

Compare with previous version

Am I right in reading from the comments in the code that you want to test this further?

Yes, I just coded this new part up without any significant testing. I also wanted to think some more about edge cases, like is is worth adding a barrier to make sure that all the unlinks on all ranks are completed before proceeding. So effectively a WIP until I find a moment.

added 69 commits

• 1dc820a7...079f0ea3 - 68 commits from branch master
• 5dad5816 - Merge remote-tracking branch 'origin/master' into restart-structs

Compare with previous version

added 1 commit

• dc3eae62 - Don't synchronize further, we have just past a barrier, so the need for that is very unlikely

Compare with previous version

All looks OK to me, so please have a look when you get a moment.

Seems all good to me, thanks!

merged

mentioned in commit c884a60d

mentioned in issue #399 (closed)