Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • SWIFTsim SWIFTsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 57
    • Issues 57
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 18
    • Merge requests 18
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • SWIFT
  • SWIFTsimSWIFTsim
  • Merge requests
  • !484

Rework of Grackle

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Loic Hausammann requested to merge grackle_rework into master Jan 05, 2018
  • Overview 5
  • Commits 9
  • Changes 6

Rework of Grackle with version change (v2 to v3).

Now the code is a lot cleaner. I think if you wish to give a first feedback, it is a good moment.

The code currently works only with the mode 0 (interpolation from a table with a very basic chemistry). In comments, there is already a beginning of the future implementation for mode 1,2 and 3.

My next steps will be to implement mode > 0 and add some parameters in the yaml file. Do you wish to wait on theses for the merge?

Reproduction of Figure 2 in https://arxiv.org/abs/1610.09591.

cooling_rate

Reproduction of Figure 8.

cooling_length

I am still getting some differences with the article, but I believe it comes from a different mode.

This graph is done with the CoolingBox test (the analytical solution is for a constant lambda cooling). energy

Edited Jan 05, 2018 by Loic Hausammann
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: grackle_rework