Doself subset vec

Adds a vectorised version of runner_doself_subset_density.

mentioned in issue #293

Is this run in the test suite at all?

It's not currently. How do I add it when it requires test27cells to be recompiled with a macro defined?

make test27cells CPPFLAGS=-DDOSELF_SUBSET
./test27cells.sh

You will need to create two different executables in Makefile.am.

In the tests directory?

Yes. I'll let you work out the syntax from the examples directory where something similar is done.

Can I not just do this in test27cells.sh.in?

touch test27cells.c
make test27cells CPPFLAGS=-DDOSELF_SUBSET

after the first three loops and copy the same loops after these two lines.

You could but that's not very elegant...

So I think I know how to compile it with macro defined just by adding:

test27cells_CFLAGS = $(AM_CFLAGS) -DDOSELF_SUBSET

to Makefile.am. Do I also need to create a separate test27cells.sh.in though?

No need. You can call both executables from the same bash script.

Ah, it was simpler than I thought. I have modified test27cells.sh to run both tests. See 96a2c2b1. Is that what you meant?

added 2 commits

• dd133666 - Only vectorise subset if Gadget SPH scheme used.
• 214e577e - Removed unnecessary variable.

Compare with previous version

added 1 commit

• ab51e592 - Fix the exit iteration padding.

Compare with previous version

added 1 commit

• c9b11f99 - Revert "Fix the exit iteration padding."

Compare with previous version

added 1 commit

• 96a2c2b1 - Build a separate exe for test27cells that runs the subset functions and add it to the test suite.

Compare with previous version

added 1 commit

• f5c3104a - Updated tolerance for the perturbed smoothing length.

Compare with previous version

added 9 commits

• f5c3104a...d6a00a8f - 8 commits from branch master
• beacd7ee - Merge branch 'master' into do_subset_vec

Compare with previous version

I've updated the branch with the latest master

added 1 commit

• fff2d7d4 - Minor style improvements.

Compare with previous version

It trust that this passes all the tests?

It passes all tests with GCC and ICC and runs the EAGLE_12 MPI test in the Jenkins script fine.

I'll let you delete the branch if you don't need it any more.

merged

mentioned in commit 602118e3