Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • SWIFTsim SWIFTsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 57
    • Issues 57
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 21
    • Merge requests 21
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • SWIFT
  • SWIFTsimSWIFTsim
  • Merge requests
  • !419

Dopair2 fix

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Matthieu Schaller requested to merge DOPAIR2_fix into master Sep 11, 2017
  • Overview 3
  • Commits 36
  • Changes 21

Large set of improvements to the hydro interactions functions:

  • Correct version of DOPAIR2() (Fixes #361 (closed)). The symmetric condition was not correctly taken into account when computing the distance on the axis.
  • Removed the old vectorization scheme from the interaction functions. This is superseded by @jwillis' work.
  • Added the check for active/inactive in the *_NAIVE() functions. These can now correctly be used throughout a run.
  • Made all the interactions take place in the frame of the cell cj for PAIRs and c for the SELFs.
  • Added a new particle type. The particles do nothing apart from recording who they interact with in the density and force loops. This is solely designed for debugging.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: DOPAIR2_fix