Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • SWIFTsim SWIFTsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 57
    • Issues 57
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 21
    • Merge requests 21
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • SWIFT
  • SWIFTsimSWIFTsim
  • Issues
  • #361
Closed
Open
Issue created Sep 05, 2017 by Matthieu Schaller@matthieuOwner

DOPAIR2 is wrong

While debugging the GPU version with @d74ksy we realised that DOPAIR2 is wrong.

The way we compute the loop start and end on the axis is incorrect as it does not match the search condition. The other scary aspect is that does not get caught by any of our unit tests. These are too nice in their particle distributions to trigger that bug. Moreover, the error we make is small (as most of the contribution comes from the SELF).

@jwillis @nnrw56 you might be interested in this.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking