Skip to content
Snippets Groups Projects

Cleaned up GIZMO code, added SineWavePotential tests.

Merged Bert Vandenbroucke requested to merge gizmo_fix into master

The GIZMO code should now be clean enough to merge with master, and to be used in scaling tests.

I have added 1-3D versions of a new SineWavePotential test, which tests gravitational hydrostatic equilibrium in an unphysical but convenient 1D periodic sine wave potential. This allows testing gravity + GIZMO hydro without running into boundary condition problems. Unfortunately, the non conservative form of the potential makes it impossible to test energy conservation in these tests. GIZMO can keep all three set ups stable with both an isothermal and an ideal gas equation of state. I have currently only tested with the exact Riemann solver, but the approximate solvers should work as well.

The code is still not stable enough to cope with the hydrostatic and disc patch tests; these are next on my list.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading