Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • SWIFTsim SWIFTsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 52
    • Issues 52
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 16
    • Merge requests 16
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • SWIFT
  • SWIFTsimSWIFTsim
  • Merge requests
  • !317

Cleaned up GIZMO code, added SineWavePotential tests.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Bert Vandenbroucke requested to merge gizmo_fix into master Mar 06, 2017
  • Overview 5
  • Commits 20
  • Changes 22

The GIZMO code should now be clean enough to merge with master, and to be used in scaling tests.

I have added 1-3D versions of a new SineWavePotential test, which tests gravitational hydrostatic equilibrium in an unphysical but convenient 1D periodic sine wave potential. This allows testing gravity + GIZMO hydro without running into boundary condition problems. Unfortunately, the non conservative form of the potential makes it impossible to test energy conservation in these tests. GIZMO can keep all three set ups stable with both an isothermal and an ideal gas equation of state. I have currently only tested with the exact Riemann solver, but the approximate solvers should work as well.

The code is still not stable enough to cope with the hydrostatic and disc patch tests; these are next on my list.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gizmo_fix