Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • SWIFTsim SWIFTsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 57
    • Issues 57
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 18
    • Merge requests 18
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • SWIFT
  • SWIFTsimSWIFTsim
  • Merge requests
  • !315

Repaired GIZMO_SPH after the time integration changes that had been made.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Bert Vandenbroucke requested to merge gizmo_fix into master Feb 28, 2017
  • Overview 0
  • Commits 5
  • Changes 12

The most important change is the addition of a new method, hydro_timestep_extra, that is called after the new time step for a particle has been computed, and that passes the physical time step for the next step to the particle. In GIZMO_SPH, this method is used to

  • store the physical time step in p->force.dt. This value is used during the force loop to exchange fluxes between particles
  • reset a new p->force.active flag to an inactive value (0). This flag is set to an active value (1) in hydro_init_part, and is used during the force loop to decide whether or not to exchange flux with particle j in the asymmetric version of the interaction method.

For all other hydro schemes, this method is empty.

Other changes:

  • made sure benchmarkInteractions compiles with GIZMO_SPH
  • added a compilation flag, GIZMO_FIX_PARTICLES, that disables particle movement. If possible, this should be replaced by a corresponding parameter
  • added some sanity checks on density and pressure values, and a proper treatment of vacuum in the gradient prediction step

This version successfully runs most of the hydro examples (including the Sod tests, Sedov blasts, Kelvin-Helmholtz test, square tests, Gresho vortex), but fails to run the 2D and 3D Noh problem (1D works).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gizmo_fix