Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • SWIFTsim SWIFTsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 57
    • Issues 57
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 21
    • Merge requests 21
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • SWIFT
  • SWIFTsimSWIFTsim
  • Merge requests
  • !259

Fix super pointer

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Matthieu Schaller requested to merge fix_super_pointer into master Sep 19, 2016
  • Overview 7
  • Commits 9
  • Changes 9

Updated the logic setting the super pointer and creating the "hierarchical" tasks (i.e. init, kick, ghost, etc.). Changes involve:

  • Getting rid of the g_super pointer. We have only one super cell per hierarchy.
  • Set the super pointer in a new routine.
  • Have only one routine to construct the hierarchical task to avoid overwriting things.
  • Moved the external gravity task to be a self with a new kind of sub-type.

The last item is necessary for the following reason. If we want to run with only external gravity (no hydro, no normal gravity), which is useful to test this aspect individually, we need to create the tasks. Now, we only create the init/kick tasks for super cells, i.e. cells that have at least one self or pair. So I promoted the external_gravity task to be a self with a new sub_type.

IMO that's more clean now. What do you think ?

Fix #215 (closed).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix_super_pointer