Replaced all calls to fminf and fmaxf by macros
As the Intel compiler can't handle these properly, here is a replacement of all calls to fmaxf
and fminf
by a macro that just encapsulates the ternary. This produces assembly call to vmaxpss
and vminpss
as expected.
Any reason not to do this ?
Merge request reports
Activity
Ah, sorry, I had missed that! Would it make any difference to mark the local variables in those "functions" as
const
?In any case, given @jwillis' results, merge it!
Reassigned to @pdraper
Added 1 commit:
- ae5712ed - Declare the temporary variables within the min/max macros as const.
I checked in https://gcc.godbolt.org/, and it doesn't make any difference, but again, for consistency throughout the code... :)
mentioned in issue #194 (closed)
mentioned in commit deda3ffe
Please register or sign in to reply