Replaced all calls to fminf and fmaxf by macros

As the Intel compiler can't handle these properly, here is a replacement of all calls to fmaxf and fminf by a macro that just encapsulates the ternary. This produces assembly call to vmaxpss and vminpss as expected.

Any reason not to do this ?

Title changed from Replaced all calls to fminf and fmaxf macros to Replaced all calls to fminf and fmaxf by macros

Did you forget to add the minmax.h file?

It has been there for a long time. I added it months ago as we needed integer min/max functions.

Ah, sorry, I had missed that! Would it make any difference to mark the local variables in those "functions" as const?

In any case, given @jwillis' results, merge it!

Reassigned to @pdraper

I don't know, you are the expert, not me ! :) My guess it that it won't as they will be optimize out but it surely can't harm.

Then please do it, if not for consistency ;)

Added 1 commit:

• ae5712ed - Declare the temporary variables within the min/max macros as const.

I checked in https://gcc.godbolt.org/, and it doesn't make any difference, but again, for consistency throughout the code... :)

Oh well.. just done it.

Like I said, I think it's good to have the consts for consistency!

BTW, that site also replicates the fminf/fmaxf bug in icc.

Let's call it a feature and not a bug then.

mentioned in issue #194 (closed)

Looks good to me, so accepting.

Status changed to merged

mentioned in commit deda3ffe