Skip to content
Snippets Groups Projects

Tom feedback

Merged Tom Theuns requested to merge TTFeedback into master

Adds a new task, which depends on kick, to perform feedback. Currently, increases the thermal energy of the particle nearest a specified SN location by a specified amount.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Added 1 commit:

    • d651d25f - Apply code formatting script. Remove unnecessary guards in the equation of state file.
  • What is the empty file src/sourceterms/Default/sourceterms_iact.h ?

  • Where is sourceterms_compute_timestep() used ?

  • Why is do_supernova_feedback() empty ?

  • In update_entropy() please use the functions provided in hydro.h. At the moment the code only compiles with Gadget-2.

  • Could the functions be properly documented ? What do they do ? What are the parameters ?

  • src/sourceterms.h 0 → 100644
    1 /*******************************************************************************
    2 * This file is part of SWIFT.
    3 * Coypright (c) 2015 Matthieu Schaller (matthieu.schaller@durham.ac.uk)
    4 *
  • src/sourceterms.c 0 → 100644
    20
    21 /* Config parameters. */
    22 #include "../config.h"
    23
    24 /* Some standard headers. */
    25 #include <math.h>
    26
    27 /* Local includes. */
    28 #include "const.h"
    29 #include "equation_of_state.h"
    30 #include "error.h"
    31 #include "parser.h"
    32 #include "part.h"
    33 #include "physical_constants.h"
    34 #include "units.h"
    35
  • 118 119 * @param c cell
    119 120 * @param timer 1 if the time is to be recorded.
    120 121 */
    122 void runner_do_sourceterms(struct runner *r, struct cell *c, int timer) {
  • 1791 1796 scheduler_addunlock(sched, t->ci->init, t);
    1792 1797 scheduler_addunlock(sched, t, t->ci->kick);
    1793 1798 }
    1799 /* source terms depend on kick (should eventually depend on cooling) */
    1800 else if (t->type == task_type_sourceterms) {
    1801 scheduler_addunlock(sched, t->ci->kick, t);
    1802 }
    1794 1803
  • Matthieu Schaller Title changed from Tt feedback to [WIP] Tt feedback

    Title changed from Tt feedback to [WIP] Tt feedback

  • Added SPH label

  • Tom Theuns Added 1 commit:

    Added 1 commit:

    • c155969a - deleted unneccesary files, made consistent with cooling
  • Tom Theuns Added 1 commit:

    Added 1 commit:

  • Tom Theuns Added 92 commits:

    Added 92 commits:

  • Tom Theuns Added 1 commit:

    Added 1 commit:

  • Tom Theuns Added 1 commit:

    Added 1 commit:

  • Author Developer

    re-merged with master. Does not work (correctly) with gizmo: need updating intrinsic/conserved quantities when calling set_thermal_energy in eos routine.

  • Matthieu Schaller Title changed from [WIP] Tt feedback to Tom feedback

    Title changed from [WIP] Tt feedback to Tom feedback

  • Tom Theuns Added 1 commit:

    Added 1 commit:

  • Tom Theuns Added 1 commit:

    Added 1 commit:

    • 436c80b6 - made sourceterms more general
  • Tom Theuns Added 1 commit:

    Added 1 commit:

    • f6e682ee - improved info provided by sourceterms
  • Matthieu Schaller Status changed to merged

    Status changed to merged

  • mentioned in commit 0f9ccb86

  • Please register or sign in to reply
    Loading