Removed calls to fminf and fmaxf in the critical sections of the code.
Is there any reason not to do this ? I have replaced calls to fminf
and fmaxf
by ternary operators. That leads to massive speed-ups.
According to vTune, we were spending large amounts of time inside these functions.
Is there any reason to use them over what I have done ? Any special behaviour of the functions that we would need in some cases ?
Merge request reports
Activity
mentioned in commit 4d45b74f
So according to the
gcc
documentation:The ISO C99 functions _Exit, acoshf, acoshl, acosh, [...], fminf, [...], vfscanf, vscanf, vsnprintf and vsscanf are handled as built-in functions except in strict ISO C90 mode (-ansi or -std=c90).
The default language mode is
-std=gnu11
, so this shouldn't be happening. @pdraper, any insight on whether this could be the cause?Otherwise, I'm curious to see what Intel have to say about it.
Edited by Pedro Gonnet