Swap order of evaluation of debugging check in gravity loops

Fixes bug #908 (closed).

requested review from @emuires

assigned to @matthieu

mentioned in issue #908 (closed)

added bug label

`[00000.2] space_rebuild: (re)building space

[00003.2] runner_others.c:runner_do_end_grav_force():875: g-particle (id=490737, type=DM) did not interact gravitationally with all other gparts gp->num_interacted=1057692, total_gparts=1057694 (local num_gparts=1057694 inhibited_gparts=0)

[00003.2] runner_others.c:runner_do_end_grav_force():875: g-particle (id=30100, type=Gas) did not interact gravitationally with all other gparts gp->num_interacted=1057691, total_gparts=1057694 (local num_gparts=1057694 inhibited_gparts=0)

Signal: SIGABRT (Aborted)`

Unfortunately, yes it works and it runs (SPH), however SW immidiately hits this.

Also, the memory is still leaking, sanitize-memory still causes a stop.

SW?

Ignore previous comment. There was an underlying issue in some checks I had done that caused this

SW - ShadowSWIFT, moving mesh. Sorry, should have clarified

Going to do a little more testing. Will report back when I cannot reproduce this issue.

Update: Unable to reproduce error on this branch or on moving_mesh_SF for either SPH or moving mesh. Happy to call it resolved for now. Even with sanitizer and optimisation it behaves

Great! Thanks for checking!

merged

mentioned in commit 5cf9f321