Skip to content
Snippets Groups Projects

circumvent oneAPI 2025 warning in restart.c

Merged Mladen Ivkovic requested to merge mladen/fix_oneapi2025_warnings into master
1 unresolved thread

Trying to compile with oneapi-2025.0.0 gets me this -Werror:

restart.c:195:18: error: variable length array folded to constant array as an extension [-Werror,-Wgnu-folding-constant]
  195 |   char signature[strlen(SWIFT_RESTART_SIGNATURE) + 1];
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

this minor change circumvents it.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
191 191 if (stream == NULL)
192 192 error("Failed to open restart file: %s (%s)", filename, strerror(errno));
193 193
194 /* Get our version and signature back. These should match. */
195 char signature[strlen(SWIFT_RESTART_SIGNATURE) + 1];
196 int len = strlen(SWIFT_RESTART_SIGNATURE);
197 restart_read_blocks(signature, len, 1, stream, NULL, "SWIFT signature");
198 signature[len] = '\0';
199 if (strncmp(signature, SWIFT_RESTART_SIGNATURE, len) != 0)
194 /* Get our version and signature back. These should match.
195 * Use static int here to avoid compiler warnings about gnu-extensions
196 * of folding a variable length array to constant array. */
197 const static int sig_len = strlen(SWIFT_RESTART_SIGNATURE);
  • Peter W. Draper unapproved this merge request

    unapproved this merge request

  • added 1 commit

    Compare with previous version

  • Thanks. Looks good now.

  • Peter W. Draper approved this merge request

    approved this merge request

  • mentioned in commit 362f580a

  • Please register or sign in to reply
    Loading